Re: A structure has changed but comment modifications maybe missed
| От | Tom Lane |
|---|---|
| Тема | Re: A structure has changed but comment modifications maybe missed |
| Дата | |
| Msg-id | 4119644.1680141729@sss.pgh.pa.us обсуждение |
| Ответ на | Re: A structure has changed but comment modifications maybe missed (David Rowley <dgrowleyml@gmail.com>) |
| Ответы |
Re: A structure has changed but comment modifications maybe missed
|
| Список | pgsql-bugs |
David Rowley <dgrowleyml@gmail.com> writes:
> I think the attached is what you have in mind. Can you confirm?
tts_nvalid is still a thing, so I question your edit here:
--- a/src/include/executor/tuptable.h
+++ b/src/include/executor/tuptable.h
@@ -68,8 +68,7 @@
* A TupleTableSlot can also be "empty", indicated by flag TTS_FLAG_EMPTY set
* in tts_flags, holding no valid data. This is the only valid state for a
* freshly-created slot that has not yet had a tuple descriptor assigned to
- * it. In this state, TTS_SHOULDFREE should not be set in tts_flags, tts_tuple
- * must be NULL and tts_nvalid zero.
+ * it. In this state, TTS_FLAG_SHOULDFREE should not be set in tts_flags.
*
* The tupleDescriptor is simply referenced, not copied, by the TupleTableSlot
* code. The caller of ExecSetSlotDescriptor() is responsible for providing
Andres would really be the expert about these changes though.
regards, tom lane
В списке pgsql-bugs по дате отправления: