Re: [COMMITTERS] pgsql: Generate fmgr prototypes automatically

On 1/17/17 2:35 PM, Tom Lane wrote:
> Peter Eisentraut <peter_e@gmx.net> writes:
>> Generate fmgr prototypes automatically
>
> BTW, now that I've looked through this patch ... why does it add
>
> +#include "nodes/nodes.h"
> +#include "nodes/pg_list.h"
>
> to utils/builtins.h?  AFAICS that shouldn't be necessary, since
> there are no declarations in builtins.h that weren't there before.
> And seeing that this results in builtins.h being included in even more
> places than before, surely we want to minimize that file's inclusion
> footprint.

There are things in builtins.h that technically need those declarations.
 It seems to work without it now, but at some point during the
refactoring they were necessary.  I can remove them again.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services