Kris Jurka wrote:
> The problem is that the 1.5 JDK has changed
> the API for ObjectFactory which means that PGObjectFactory and
> Jdbc3ObjectFactory cannot be compiled at the moment.
Aha, I see. generics strike again.
We could deal with the non-pooling datasources by no longer implementing
Referenceable and relying on serialization to preserve state. Then we do
not need an ObjectFactory at all.
For pooling DataSources (I mean jdbc2.optional.PoolingDataSource, not
jdbc2.optional.ConnectionPool -- those are badly named!) we could
implement readResolve()/writeReplace() to translate to/from a lookup
handle into the registry of known pools when serialized. But that gets a
bit hairy. It's probably simpler to just do conditional compilation of
the signature of PGObjectFactory.getObjectInstance() if we want to
support the pooling DataSources.
I'm actually tempted to drop the pooling DataSource implementations
altogther. Does anyone on the list actually use these? I think the more
common approach is for a higher layer to use our
ConnectionPoolDataSource implementation (or plain DataSource, even) plus
their own pooling logic..
-O