On 2020/04/09 23:10, Stephen Frost wrote:
> Greetings,
>
> * Fujii Masao (masao.fujii@oss.nttdata.com) wrote:
>> On 2020/04/09 2:35, Robert Haas wrote:
>>> On Wed, Apr 8, 2020 at 1:15 AM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>>> When there is a backup_manifest in the database cluster, it's included in
>>>> the backup even when --no-manifest is specified. ISTM that this is problematic
>>>> because the backup_manifest is obviously not valid for the backup.
>>>> So, isn't it better to always exclude the *existing* backup_manifest in the
>>>> cluster from the backup, like backup_label/tablespace_map? Patch attached.
>>>>
>>>> Also I found the typo in the document. Patch attached.
>>>
>>> Both patches look good. The second one is definitely a mistake on my
>>> part, and the first one seems like a totally reasonable change.
>>> Thanks!
>>
>> Thanks for reviewing them! I pushed them.
>>
>> Please note that the commit messages have not been delivered to
>> pgsql-committers yet.
>
> They've been released and your address whitelisted.
Many thanks!!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION