>
On 2026-01-06 Tu 1:26 AM, Mahendra Singh Thalor wrote:
>
>> It's probably harmless, we connect to the databases further down to do actual work. But it's also not nice. The
toc.gloseems to have a bunch of extraneous entries of type COMMENT and CONNECT. Why is that? As far as poible this
shouldhave output pretty much identical to a plain pg_dumpall.
>>
>>
> If we don't dump those comments in non-text format, then the output of
> "pg_restore -f filename dump_non_text" will not be the same as the
> plain dump of pg_dumpall.
>
> Here, I am attaching an updated patch for the review and testing.
>
> Note: some of the review comments are still not fixed. I am working on
> those and will post an updated patch.
But these cases are not producing anything like identical output.
here is the diff produced by my standard test case. (I have modified the
output to unify the resttrict/unrestrict keys)
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com