Re: SKIP LOCKED assert triggered

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Pushed, thanks Simon for reporting this problem.

Umm ...

       Assert(TM_WouldBlock || !(tuple->t_data->t_infomask & HEAP_XMAX_INVALID));

AFAICS, this assertion condition is constant-true,
because TM_WouldBlock is a nonzero constant.  Perhaps you meant

       Assert(result == TM_WouldBlock || !(tuple->t_data->t_infomask & HEAP_XMAX_INVALID));

?

I'd be inclined to format it more like the adjacent Assert, too.

            regards, tom lane