Re: Covering GiST indexes

От: Andreas Karlsson
Тема: Re: Covering GiST indexes
Дата: ,
Msg-id: 402f2560-774e-69df-3bdd-10b2dea8e1d5@proxel.se
(см: обсуждение, исходный текст)
Ответ на: Re: Covering GiST indexes  (Andrey Borodin)
Ответы: Re: Covering GiST indexes  (Andrey Borodin)
Список: pgsql-hackers

Скрыть дерево обсуждения

Covering GiST indexes  (Andrey Borodin, )
 Re: Covering GiST indexes  (Teodor Sigaev, )
  Re: Covering GiST indexes  (Aleksander Alekseev, )
  Re: Covering GiST indexes  (Andrey Borodin, )
   Re: Covering GiST indexes  (Andrey Borodin, )
    Re: Covering GiST indexes  (Thomas Munro, )
     Re: Covering GiST indexes  (Andrey Borodin, )
      Re: Covering GiST indexes  (Thomas Munro, )
       Re: Covering GiST indexes  (Andrey Borodin, )
        Re: Covering GiST indexes  (Dmitry Dolgov, )
         Re: Covering GiST indexes  (Andrey Borodin, )
          Re: Covering GiST indexes  (Andreas Karlsson, )
           Re: Covering GiST indexes  (Andrey Borodin, )
            Re: Covering GiST indexes  (Andreas Karlsson, )
             Re: Covering GiST indexes  (Andrey Borodin, )
              Re: Covering GiST indexes  (Andreas Karlsson, )
               Re: Covering GiST indexes  (Andreas Karlsson, )
               Re: Covering GiST indexes  (Andrey Borodin, )
                Re: Covering GiST indexes  (Andreas Karlsson, )
                 Re: Covering GiST indexes  (Andrey Borodin, )
                  Re: Covering GiST indexes  (Andreas Karlsson, )
                   Re: Covering GiST indexes  (Alexander Korotkov, )
                    Re: Covering GiST indexes  (Alexander Korotkov, )
                     Re: Covering GiST indexes  (Andrey Borodin, )
 Re: Covering GiST indexes  (Alexander Korotkov, )
  Re: Covering GiST indexes  (Darafei "Komяpa" Praliaskouski, )
   Re: Covering GiST indexes  (Alexander Korotkov, )
 Re: Covering GiST indexes  (Peter Geoghegan, )

On 29/01/2019 18.45, Andrey Borodin wrote:
> Also, I've unified gist and r-tree syntax tests for INCLUDE.

Why not just keep it simple? The purpose is not to test the GiST 
indexes, for that we have index_including_gist.sql.

I propose the following.

/*
  * 7. Check various AMs. All but btree and gist must fail.
  */
CREATE TABLE tbl (c1 int,c2 int, c3 box, c4 box);
CREATE INDEX on tbl USING brin(c1, c2) INCLUDE (c3, c4);
CREATE INDEX on tbl USING gist(c3) INCLUDE (c1, c4);
CREATE INDEX on tbl USING spgist(c3) INCLUDE (c4);
CREATE INDEX on tbl USING gin(c1, c2) INCLUDE (c3, c4);
CREATE INDEX on tbl USING hash(c1, c2) INCLUDE (c3, c4);
CREATE INDEX on tbl USING rtree(c3) INCLUDE (c1, c4);
DROP TABLE tbl;

and

/*
  * 7. Check various AMs. All but btree and gist must fail.
  */
CREATE TABLE tbl (c1 int,c2 int, c3 box, c4 box);
CREATE INDEX on tbl USING brin(c1, c2) INCLUDE (c3, c4);
ERROR:  access method "brin" does not support included columns
CREATE INDEX on tbl USING gist(c3) INCLUDE (c1, c4);
CREATE INDEX on tbl USING spgist(c3) INCLUDE (c4);
ERROR:  access method "spgist" does not support included columns
CREATE INDEX on tbl USING gin(c1, c2) INCLUDE (c3, c4);
ERROR:  access method "gin" does not support included columns
CREATE INDEX on tbl USING hash(c1, c2) INCLUDE (c3, c4);
ERROR:  access method "hash" does not support included columns
CREATE INDEX on tbl USING rtree(c3) INCLUDE (c1, c4);
NOTICE:  substituting access method "gist" for obsolete method "rtree"
DROP TABLE tbl;



В списке pgsql-hackers по дате сообщения:

От: Andres Freund
Дата:
Сообщение: Re: COPY FROM WHEN condition
От: Michael Paquier
Дата:
Сообщение: Re: A few new options for vacuumdb