Here are two WIP patches to improve the DefElem list processing that is
used by many utility commands.
One factors out the duplicate checks, which are currently taking up a
lot of space with duplicate code. I haven't applied this everywhere
yet, but the patch shows how much boring code can be saved.
The other adds a location field to the DefElem node. This allows
showing an error pointer if there is a problem in one of the options,
which can be useful for complex commands such as COPY or CREATE USER.
At the moment, these patches are independent and don't work together,
but the second one would become much easier if the first one is accepted.
If these ideas are acceptable, I'll produce a complete patch series.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services