Re: Buffer locking is special (hints, checksums, AIO writes)
| От | Andres Freund |
|---|---|
| Тема | Re: Buffer locking is special (hints, checksums, AIO writes) |
| Дата | |
| Msg-id | 3w7v3w6a57jnssokap4k7thoekig72flnyhd4wp3yftzdd7lm7@f6lpcfen6hr7 обсуждение исходный текст |
| Ответ на | Re: Buffer locking is special (hints, checksums, AIO writes) (Andres Freund <andres@anarazel.de>) |
| Список | pgsql-hackers |
On 2025-10-09 16:35:44 -0400, Andres Freund wrote: > I pushed a few commits from this patchset after Matthias' review > (thanks!). Unfortunately in 5e899859287 I missed that the valgrind annotations > would not be done anymore for the buffers returned by > StrategyGetBuffer(). Which turned skink red. > > The attached 0001 patch centralizes the valgrind initialization in > TrackNewBufferPin(), which 5e899859287 had added. The nice side effect of that > is that there are fewer VALGRIND_MAKE_MEM_DEFINED() calls than before. The > naming isn't the perfect match, but it seems fine to me. Forgot to say: I'll push this patch soon, to get skink back to green. Unless somebody says something. We can adjust this later, if the comment and/or placement of VALGRIND_MAKE_MEM_DEFINED() isn't to everyones liking.
В списке pgsql-hackers по дате отправления: