Re: pgsql: Add support for basic NUMA awareness

Hi,

On 2025-04-08 17:17:21 +0200, Wolfgang Walther wrote:
> Andres Freund:
> > But I'm rather bewildered - I can't actually build with the professed version
> > of ninja, it errors out:
> > 
> > ninja-1.9.0 src/bin/psql/sql_help.c
> > ninja: error: build.ninja:8462: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing
listif it affects you
 
> > 
> > So this must be some version of ninja between 1.9 and 1.10 (where the multiple
> > outputs support was added).
> > 
> > What's particularly weird about that is that the rest of the distro seems much
> > newer. gcc 14.2.1, meson 1.6.1, LLVM 18. What's a < 2020 ninja doing with
> > those surroundings?
> 
> The Dockerfile for the image running dogfish is at [1]. I'm installing the
> package "ninja" there, which... doesn't even exist upstream [2]. Odd. There
> is ninja-build, though, which is at 1.12.1. [3]
> 
> Turns out that the "ninja" I am installing is provided by samurai [4], which
> seems to be a drop-in replacement [5] for ninja:
> 
> > samurai implements the ninja build language through version 1.9.0 except
> for MSVC dependency handling (deps = msvc). It uses the same format for
> .ninja_log and .ninja_deps as ninja, currently version 5 and 4 respectively.
> 
> I have not followed the remainder of the thread.. would you rather have me
> try to switch to the real ninja, or should we keep samurai for some
> variation in the buildfarm?

Ah, that explains that.  Since it seems to be working, that one warning aside,
I don't mind if it continues running with it.  But it'd be nice to add a note
to the buildfarm animal indicating it's using samurai instead of ninja
(setnotes.pl).

Greetings,

Andres Freund