Re: PATCH: Exclude additional directories in pg_basebackup

On 9/6/16 10:25 PM, Michael Paquier wrote:
> On Wed, Sep 7, 2016 at 12:16 AM, David Steele <david@pgmasters.net> wrote:
>> Attached is a new patch that adds sgml documentation.  I can expand on each
>> directory individually if you think that's necessary, but thought it was
>> better to lump them into a few categories.
> 
> +    be ommitted from the backup as they will be initialized on postmaster
> +    startup. If the <xref linkend="GUC-STATS-TEMP-DIRECTORY"> is set and is
> +    under the database cluster directory then the contents of the directory
> +    specified by <xref linkend="GUC-STATS-TEMP-DIRECTORY"> can also
> be ommitted.
> 
> s/ommitted/omitted/

Thanks!

> +#define EXCLUDE_DIR_MAX         8
> +#define EXCLUDE_DIR_STAT_TMP     0
> +
> +const char *excludeDirContents[EXCLUDE_DIR_MAX] =
> +{
> +    /*
> +     * Skip temporary statistics files. The first array position will be
> +     * filled with the value of pgstat_stat_directory relative to PGDATA.
> +     * PG_STAT_TMP_DIR must be skipped even when stats_temp_directory is set
> +     * because PGSS_TEXT_FILE is always created there.
> +     */
> +    NULL,
> I find that ugly. I'd rather use an array with undefined size for the
> fixed elements finishing by NULL, remove EXCLUDE_DIR_MAX and
> EXCLUDE_DIR_STAT_TMP and use a small routine to do the work done on
> _tarWriteHeader...

My goal was to be able to fully reuse the code that creates the paths,
but this could also be done by following your suggestion and also moving
the path code into a function.

Any opinion on this, Peter?

-- 
-David
david@pgmasters.net