Re: Exit walsender before confirming remote flush in logical replication
| От | Andrey Silitskiy |
|---|---|
| Тема | Re: Exit walsender before confirming remote flush in logical replication |
| Дата | |
| Msg-id | 3d024a19-1256-4177-942a-d7173dacba74@postgrespro.ru обсуждение исходный текст |
| Ответ на | Re: Exit walsender before confirming remote flush in logical replication (Fujii Masao <masao.fujii@gmail.com>) |
| Ответы |
Re: Exit walsender before confirming remote flush in logical replication
|
| Список | pgsql-hackers |
On Jan 9, 2026 at 10:04 AM Fujii Masao
<masao(dot)fujii(at)gmail(dot)com> wrote:
> Why do we need to send a "done" message to the receiver here?
> Since delivery isn't guaranteed in immediate mode, it seems of limited
> value.
It seems to me that it is better to send a message in cases where it is
possible, so as not to raise errors on the subscriber during a clean shutdown.
And when this is not possible, exit the process without waiting.
> For the immediate mode, would it make sense to log that the walsender is
> terminating in immediate mode and that WAL replication may be incomplete,
> so users can more easily understand what happened?
Added to the latest patch.
Regards,
Andrey Silitskiy
<masao(dot)fujii(at)gmail(dot)com> wrote:
> Why do we need to send a "done" message to the receiver here?
> Since delivery isn't guaranteed in immediate mode, it seems of limited
> value.
It seems to me that it is better to send a message in cases where it is
possible, so as not to raise errors on the subscriber during a clean shutdown.
And when this is not possible, exit the process without waiting.
> For the immediate mode, would it make sense to log that the walsender is
> terminating in immediate mode and that WAL replication may be incomplete,
> so users can more easily understand what happened?
Added to the latest patch.
Regards,
Andrey Silitskiy
В списке pgsql-hackers по дате отправления: