Re: Change pgarch_readyXlog() to return .history files first

On 12/21/18 6:49 AM, Kyotaro HORIGUCHI wrote:
> "else if (!historyFound || ishistory)"
> 
> 
> 
>>         strcpy(xlog, newxlog);
> 
> The caller prepares sufficient memory for basename, and we no
> longer copy ".ready" into newxlog. Douldn't we work directly on
> xlog instead of allocating newxlog?

I thought about doing that, but wanted to focus on the task at hand.  It 
does save a strcpy and a bit of stack space, so seems like a win.

Overall, the patch looks good to me.  I think breaking up the if does 
make the code more readable.

Regards,
-- 
-David
david@pgmasters.net