Hi,
On 12/13/23 3:33 PM, Michael Paquier wrote:
> On Tue, Dec 12, 2023 at 04:54:32PM -0300, Euler Taveira wrote:
>> Couldn't it give up before starting if you apply your patch? My main concern is
>> due to a slow system, the walrcv_connect() took to long in WalReceiverMain()
>> and the code above kills the walreceiver while in the process to start it.
>> Since you cannot control the hardcoded WALRCV_STARTUP_TIMEOUT value, you might
>> have issues during overload periods.
>
> Sounds like a fair point to me,
Thanks for looking at it! I'm not sure about it, see my comment in [1].
> Another thing that I'm a bit surprised with is why it would be OK to
> switch the status to STREAMING only we first_stream is set, discarding
> the restart case.
Yeah, that looks like a miss on my side. Thanks for pointing out!
Please find attached v2 addressing this remark.
[1]: https://www.postgresql.org/message-id/c76c0a65-f754-4614-b616-1d48f9195745%40gmail.com
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com