On 2024-04-04 Th 14:06, Nathan Bossart wrote:
> Apologies for piling on, but my compiler (gcc 9.4.0) is unhappy:
>
> ../postgresql/src/common/jsonapi.c: In function ‘IsValidJsonNumber’:
> ../postgresql/src/common/jsonapi.c:2016:30: error: ‘dummy_lex.inc_state’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
> 2016 | if (lex->incremental && !lex->inc_state->is_last_chunk &&
> | ~~~^~~~~~~~~~~
> ../postgresql/src/common/jsonapi.c:2020:36: error: ‘dummy_lex.token_start’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
> 2020 | lex->token_start, s - lex->token_start);
> | ~~~^~~~~~~~~~~~~
> ../postgresql/src/common/jsonapi.c:302:26: error: ‘numeric_error’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
> 302 | return (!numeric_error) && (total_len == dummy_lex.input_length);
> | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
Please pile on. I want to get this fixed.
It seems odd that my much later gcc didn't complain.
Does the attached patch fix it for you?
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com