Re: [HACKERS] Current Win32 port status

Поиск
Список
Период
Сортировка
От Andrew Dunstan
Тема Re: [HACKERS] Current Win32 port status
Дата
Msg-id 3FE737C2.7080105@dunslane.net
обсуждение исходный текст
Ответ на Re: [HACKERS] Current Win32 port status  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers-win32
Tom Lane wrote:

>
>AFAIR there is no place in Postgres where performance of a pipe
>connection is critical.  Don't go out of your way to make it fast.
>
>In fact, right offhand I only see two pipes used at all in the source
>code: they are both in pgstat.c.  It's fairly likely that that could be
>redesigned if it poses a problem on Windows.  (One of the pipes never
>even transports any data; it's only used as a cheap-and-dirty means of
>letting the statistics subprocess detect postmaster exit.)
>
>
>

You are correct - I noticed that. Also, the only places in the backend
where we seem to use select() on FDs are in pgstat.c and postmaster.c,
and in the latter case the FDs *are* sockets, so we won't have a problem
there on Windows. There are a couple of other places where it is used
for small sleeps (storage/lmgr/s_lock.c and access/transam/xact.c) -
those should possibly be abstracted out (Windows doesn't behave well
there anyway, I believe - with 0 FDs I read somewhere it returns
immediately regardless of the timeout setting).

Bottom line: this should be a very small nut to crack.

cheers

andrew




В списке pgsql-hackers-win32 по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: [HACKERS] Current Win32 port status
Следующее
От: Claudio Natoli
Дата:
Сообщение: Re: [HACKERS] Current Win32 port status