Tom Lane wrote:
>AFAICS mkdatadir() shouldn't consider subdir == NULL as a reason to
>fail rather than trying mkdir_p. Indeed, if anything the opposite:
>when subdir isn't NULL the immediately prior directory level should
>exist already.
>
Right. In fact, I can't see any good reason to call mkdir and then
mkdir_p at all. See my patch from this afternoon.
>
>I concur with Peter's gripe that a perror() or two wouldn't hurt here.
>
Sure. Of course, the reason I put this on my web site and asked for
eyeballs was to try to catch some of this sort of stuff before the
program went into the tree :-)
cheers
andrew