Tom Lane wrote:
> Hm. I'd sort of expect the "z" to become both the table and column
> alias in this case. What do you think?
I guess that would make sense. I'll make a separate patch just for that
change if that's OK.
> Other examples look good. Code style comment:
>
>
>>+ if (functyptype != 'p' || (functyptype == 'p' && funcrettype != RECORDOID))
>
>
> This test seems redundant, why not
>
> if (functyptype != 'p' || funcrettype != RECORDOID)
>
You're correct, of course. But I started out with a much more convoluted
test than that, so at least this was an improvement ;-)
Joe