Re: unknownin/out patch (was [HACKERS] PQescapeBytea is

Поиск
Список
Период
Сортировка
От Joe Conway
Тема Re: unknownin/out patch (was [HACKERS] PQescapeBytea is
Дата
Msg-id 3CB103C8.1000909@joeconway.com
обсуждение исходный текст
Ответ на unknownin/out patch (was [HACKERS] PQescapeBytea is not multibyte aware)  (Joe Conway <mail@joeconway.com>)
Ответы Re: unknownin/out patch  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-patches
Joe Conway wrote:
> Here's a patch to add unknownin/unknownout support. I also poked around
> looking for places that assume UNKNOWN == TEXT. One of those was the
> "SET" type in pg_type.h, which was using textin/textout. This one I took
> care of in this patch. The other suspicious place was in
> string_to_dataum (which is defined in both selfuncs.c and indxpath.c). I
> wasn't too sure about those, so I left them be.
>

I found three other suspicious spots in the source, where UNKNOWN ==
TEXT is assumed. The first looks like it needs to be changed for sure,
the other two I'm less sure about. Feedback would be most appreciated
(on this and the patch itself).

(line numbers based on CVS from earlier today)
parse_node.c
line 428
parse_coerce.c
line 85
parse_coerce.c
line 403

Joe



В списке pgsql-patches по дате отправления:

Предыдущее
От: Joe Conway
Дата:
Сообщение: unknownin/out patch (was [HACKERS] PQescapeBytea is not multibyte aware)
Следующее
От: Tom Lane
Дата:
Сообщение: Re: unknownin/out patch (was [HACKERS] PQescapeBytea is not multibyte aware)