Re: [oauth] Bug: when is shutdown_cb called?

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: [oauth] Bug: when is shutdown_cb called?
Дата
Msg-id 3C6699FD-277A-454A-A221-784DC13F392D@gmail.com
обсуждение исходный текст
Ответ на Re: [oauth] Bug: when is shutdown_cb called?  (Jacob Champion <jacob.champion@enterprisedb.com>)
Список pgsql-hackers

> On Feb 28, 2026, at 00:55, Jacob Champion <jacob.champion@enterprisedb.com> wrote:
>
> On Wed, Feb 18, 2026 at 4:50 AM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>> Maybe we should just fix the documentation instead?
>
> Yeah, this is just a docs bug. It changed in v47 of the original
> patchset [1] but I forgot to update the documentation. (It was
> originally a before_shmem_exit implementation, which is why that fits
> the description well. :D)
>
> I propose the attached diff, with a backport to 18.
>
>> The advantages: things like expiration checks[2], or repeated
>> validation in the future when we implement token refresh need a
>> working validator state, which means either we have to call
>> startup/shutdown multiple times, or keep the context.
>
> Personally I think it's fine for more complicated behavior to require
> more integration into the existing server APIs. We don't need to
> reinvent OAuth-specific wheels; implementations will just need to pay
> attention to memory contexts and _PG_init like standard extensions
> already do.
>
> Thanks,
> --Jacob
>
> [1] https://www.postgresql.org/message-id/CAOYmi%2BnHG7oy%2BybHH72WjiXAQG3tE6v_at-K9ebRy2oqo92V%2BA%40mail.gmail.com
> <shutdown-docs.diff>

```
+    The <function>shutdown_cb</function> callback is executed when the server
+    backend has finished validating tokens for the connection. If the validator
```

“Server backend” sounds a bit uncommon in the documentation. I searched through the *.sgml files and couldn’t find much
occurrencesof that phrase. It seems that “backend process” is used consistently elsewhere. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







В списке pgsql-hackers по дате отправления: