Change in rule behavior?

Поиск
Список
Период
Сортировка
От Sergio Pili
Тема Change in rule behavior?
Дата
Msg-id 3C016EF8.AB649B9F@sinectis.com.ar
обсуждение исходный текст
Ответы Re: Change in rule behavior?
Список pgsql-hackers
Hello,

I need use a notify in rules with where conditions. In 7.1.3, i found a
bug and i fix it. Then I downloaded the version 7.2 to verify the bug
and to send them the patch, but the behavior had been changed.

test=# select version();
                               version
---------------------------------------------------------------------
 PostgreSQL 7.1.3 on i686-pc-linux-gnu, compiled by GCC egcs-2.91.66
(1 row)


The tables:

test=# \d rd
          Table "rd"
 Column |   Type   | Modifiers
--------+----------+-----------
 a      | smallint |
 b      | smallint |
 c      | text     |

            Table "ri"
 Column |   Type   |  Modifiers
--------+----------+--------------
 d      | smallint |
 e      | text     |
 a      | smallint | default 1000
 b      | smallint | default 2000

When i try to create the rule:

CREATE RULE upd_rd
AS ON
UPDATE TO ri
WHERE
        NEW.a IS NOT NULL
    AND NEW.b IS NOT NULL
DO (
        notify foo;
        update rd set a=new.a,b=new.b
        where a=old.a and b=old.b;
)

the output was:

psql:sql/rd_ri/bug_upd.sql:11: pqReadData() -- backend closed the
channel unexpectedly.
        This probably means the backend terminated abnormally
        before or while processing the request.
psql:sql/rd_ri/bug_upd.sql:11: connection to server was lost


I fix it with the attached patch and the rule works well. But in 7.2b2 i
can't do it...

With the same rule, when i when I try to create it in 7.2b3 the output
was:

test=# select version();
                               version
---------------------------------------------------------------------
 PostgreSQL 7.2b3 on i686-pc-linux-gnu, compiled by GCC egcs-2.91.66
(1 row)

psql:sql/rd_ri/bug_upd.sql:11: ERROR:  Rules with WHERE conditions may
only have SELECT, INSERT, UPDATE, or DELETE actions


Why was changed?
Is it possible to maintain the previous behavior  with my correction?

Thanks in advance,
Sergio*** ./src/backend/parser/analyze.c.orig    Sun Nov 25 17:44:19 2001
--- ./src/backend/parser/analyze.c    Sun Nov 25 17:49:46 2001
***************
*** 1759,1765 ****
               * wrong to fail to make a jointree entry if only NEW and not
               * OLD is mentioned.
               */
!             if (has_old || (has_new && stmt->event == CMD_UPDATE))
              {
                  /* hack so we can use addRTEtoQuery() */
                  sub_pstate->p_rtable = sub_qry->rtable;
--- 1759,1766 ----
               * wrong to fail to make a jointree entry if only NEW and not
               * OLD is mentioned.
               */
!             if ((has_old || (has_new && stmt->event == CMD_UPDATE)) &&
!                 (top_subqry->commandType != CMD_UTILITY))
              {
                  /* hack so we can use addRTEtoQuery() */
                  sub_pstate->p_rtable = sub_qry->rtable;

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Eisentraut
Дата:
Сообщение: Re: OCTET_LENGTH is wrong
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Call for objections: deprecate postmaster -o switch?