> On 17 Jun 2021, at 09:29, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, May 20, 2021 at 08:40:48PM +0200, Daniel Gustafsson wrote:
>>> On 19 May 2021, at 21:05, Andrew Dunstan <andrew@dunslane.net> wrote:
>>>
>>> On 5/19/21 1:01 PM, Dagfinn Ilmari Mannsåker wrote:
>>>> Daniel Gustafsson <daniel@yesql.se> writes:
>>>>
>>>>> In order to be able to test extensions with SSL connections, allow
>>>>> configure_test_server_for_ssl to create any extensions passed as
>>>>> comma separated list. Each extension is created in all the test
>>>>> databases which may or may not be useful.
>>>> Why the comma-separated string, rather than an array reference,
>>>> i.e. `extensions => [qw(foo bar baz)]`?
>>
>> No real reason, I just haven't written Perl enough lately to "think in Perl".
>> Fixed in the attached.
>
> Hmm. Adding internal dependencies between the tests should be avoided
> if we can. What would it take to move those TAP tests to
> contrib/sslinfo instead? This is while keeping in mind that there was
> a patch aimed at refactoring the SSL test suite for NSS.
It would be quite invasive as we currently don't provide the SSLServer test
harness outside of src/test/ssl, and given how tailored it is today I'm not
sure doing so without a rewrite would be a good idea.
A longer term solution would probably be to teach PostgresNode to provide an
instance set up for TLS in case the backend is compiled with TLS support, and
use that for things like sslinfo.
--
Daniel Gustafsson https://vmware.com/