Re: Issue in GIN fast-insert: XLogBeginInsert + Read/LockBuffer ordering

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Oct 24, 2022 at 02:22:16PM +0200, Alvaro Herrera wrote:
>> I confess I don't understand why is it important that XLogBeginInsert is
>> called inside the critical section.  It seems to me that that part is
>> only a side-effect of having to acquire the buffer locks in the critical
>> section.  Right?

> Yeah, you are right that it would not matter for XLogBeginInsert(),
> though I'd like to think that this is a good practice on consistency
> grounds with anywhere else, and we respect what's documented in the
> README.

Yeah --- it's documented that way, and there doesn't seem to be
a good reason not to honor that here.

            regards, tom lane