On 03.03.25 19:45, Matheus Alcantara wrote:
> Hi, attached a new v5 with some minor improvements on TAP tests:
>
> - Add a proper test name for all test cases
> - Add CREATE EXTENSION command execution
> - Change the assert on pg_available_extensions and
> pg_available_extension_versions to validate the row content
>
> Also rebased with master
This looks very good to me. I have one issue to point out: The logic
in get_extension_control_directories() needs to be a little bit more
careful to align with the rules in find_in_path(). For example, it
should use first_path_var_separator() to get the platform-specific path
separator, and probably also substitute_path_macro() and
canonicalize_path() etc., to keep everything consistent. (Maybe it
would be ok to move the function to dfmgr.c to avoid having to export
too many things from there.)
Independent of that, attached is a small patch that suggests to use the
newer foreach_ptr() macro in some places.