Andres Freund <andres@anarazel.de> wrote:
> Probably need to update the comments a bit. What about something like
>
>
> /*
> * Is the snapshot implemented as an MVCC snapshot (i.e. it uses
> * SNAPSHOT_MVCC). If so, there will be at most be one visible row in a chain
> * of updated tuples, and each visible tuple will be seen exactly once.
> */
> #define IsMVCCSnapshot(snapshot) \
The ", and each visible tuple ..." part seemed to me redundant, so I omitted
it. If you think I'm wrong, please add it yourself when committing the patch.
I also added a comment to the IsHistoricMVCCSnapshot(), trying to explain what
"historic" means.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com