Re: pgsql: Unbreak recovery test on Windows
| От | Tom Lane |
|---|---|
| Тема | Re: pgsql: Unbreak recovery test on Windows |
| Дата | |
| Msg-id | 387848.1616350601@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: pgsql: Unbreak recovery test on Windows (Andrew Dunstan <andrew@dunslane.net>) |
| Ответы |
Re: pgsql: Unbreak recovery test on Windows
|
| Список | pgsql-committers |
Andrew Dunstan <andrew@dunslane.net> writes:
> Ugh. Is there any reason we need to do those kills before we end the
> psql processes? If not I'm tempted just to move them - after the psql's
> are finished it should be safe. At any rate I'll go and test that.
IIUC, that'd completely destroy the point of the test, which is to make
sure we clean up when a backend dies unexpectedly. If we allow the
psql's to exit then the backend might be able to complete normal cleanup
before we can SIGKILL it.
Probably the best thing for now is to revert your change and instead
just skip the whole test script on Windows.
regards, tom lane
В списке pgsql-committers по дате отправления: