Re: BUG #2072: CPPFLAGS clobbered

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: BUG #2072: CPPFLAGS clobbered
Дата
Msg-id 3768.1133023171@sss.pgh.pa.us
обсуждение исходный текст
Ответ на BUG #2072: CPPFLAGS clobbered  ("Keith Randall" <randallk@gmail.com>)
Список pgsql-bugs
"Keith Randall" <randallk@gmail.com> writes:
> In src/template/linux the
> CPPFLAGS="-D_GNU_SOURCE"
> overrides command-line CPPFLAGS
> I change it to
> CPPFLAGS="$CPPFLAGS -D_GNU_SOURCE"
> and am back in business.

That's pretty much entirely the wrong way to fix it; or at least it's
inconsistent with the way we handle CFLAGS etc, and doing it this way
would require touching every template not only linux.

I'm thinking that configure.in should handle template CPPFLAGS settings
the same way it handles CFLAGS, ie, command line settings override the
template.  Probably LDFLAGS too.

BTW, why do you feel a need to override CPPFLAGS in the first place?

            regards, tom lane

В списке pgsql-bugs по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: BUG #2071: ERROR: invalid multibyte character for locale
Следующее
От: Bruce Momjian
Дата:
Сообщение: Re: Patch to allow contrib/pgbench files to have blank lines