Re: [PATCHES] WAL: O_DIRECT and multipage-writer

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCHES] WAL: O_DIRECT and multipage-writer
Дата
Msg-id 3763.1106668598@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCHES] WAL: O_DIRECT and multipage-writer  (ITAGAKI Takahiro <itagaki.takahiro@lab.ntt.co.jp>)
Ответы Re: WAL: O_DIRECT and multipage-writer  (ITAGAKI Takahiro <itagaki@tiara.ocn.ne.jp>)
Список pgsql-hackers
ITAGAKI Takahiro <itagaki.takahiro@lab.ntt.co.jp> writes:
> I resend the patch with diff -c.

What does XLOG_EXTRA_BUFFERS accomplish?

Also, I'm worried that you broke something by not updating
Write->curridx immediately in XLogWrite.  There certainly isn't going
to be any measurable performance boost from keeping that in a local
variable, so why take any risk?

            regards, tom lane

В списке pgsql-hackers по дате отправления:

Предыдущее
От: "J Roy"
Дата:
Сообщение: how to set password while loging into database
Следующее
От: Christopher Browne
Дата:
Сообщение: Re: Goals for 8.1