Re: Built-in CTYPE provider

Jeff Davis <pgsql@j-davis.com> writes:
> It may be moot soon, but I committed a fix now.

Thanks, but it looks like 846311051 introduced a fresh issue.
MSVC is complaining about

[21:37:15.349] c:\cirrus\src\backend\utils\adt\pg_locale.c(2515) : warning C4715: 'builtin_locale_encoding': not all
controlpaths return a value 

This is causing all CI jobs to fail the "compiler warnings" check.

Probably the best fix is the traditional

    return <something>;    /* keep compiler quiet */

but I'm not sure what the best default result is in this function.

            regards, tom lane