Re: pg_waldump: support decoding of WAL inside tarfile

Thomas Munro <thomas.munro@gmail.com> writes:
> Thanks.  I'll go ahead and push v2 shortly, which includes Sami's
> change (with credit), unless you have any better ideas for that bit.

Not really.  I wondered for a bit if it was smart to create tar files
whose contents would appear root-owned, but it could only matter if
somebody extracted such a file as root, and I don't see a plausible
pathway for that to happen, since these are merely transient test
files.

We could dodge that hazard by using, say, "--owner=1" but I'm
not sure whether that'd introduce its own problems.  In any case,
walmethods.c's tar_open_for_write is already filling in zeroes
there.

            regards, tom lane