Re: DOC: fixes multiple errors in alter table doc
| От | Chao Li |
|---|---|
| Тема | Re: DOC: fixes multiple errors in alter table doc |
| Дата | |
| Msg-id | 3692340C-3E24-46EE-94EE-2CE88B6F470E@gmail.com обсуждение исходный текст |
| Ответ на | Re: DOC: fixes multiple errors in alter table doc (Chao Li <li.evan.chao@gmail.com>) |
| Ответы |
Re: DOC: fixes multiple errors in alter table doc
|
| Список | pgsql-hackers |
> On Mar 6, 2026, at 14:48, Chao Li <li.evan.chao@gmail.com> wrote: > > > >> On Mar 6, 2026, at 14:40, Fujii Masao <masao.fujii@gmail.com> wrote: >> >> On Thu, Mar 5, 2026 at 2:06 PM Chao Li <li.evan.chao@gmail.com> wrote: >>>> -- alter noexisting table >>>> ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD COLUMN c4 integer; >>>> +ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 ADD c5 integer; >>>> <snip> >>>> ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP COLUMN IF EXISTS no_column; >>>> +ALTER FOREIGN TABLE IF EXISTS doesnt_exist_ft1 DROP IF EXISTS no_column; >>>> >>>> Regarding 0002 patch, could you explain the reason for adding these >>>> two additional tests? I was just curious why because other four tests that >>>> the patch adds seem sufficient. >>> >>> They are combinations of “IF [NOT] EXISTS” and omitting “COLUMN", I added them just for better coverage. >> >> Which table-level or column-level "IF [NOT] EXISTS" are you referring to? >> If you mean the combination of column-level "IF [NOT] EXISTS" with >> "COLUMN" omitted, then the first test above should be "ALTER FOREIGN TABLE >> IF EXISTS doesnt_exist_ft1 ADD IF NOT EXISTS c5 integer"? >> >> Regards, >> >> -- >> Fujii Masao > > I meant to say column-level. Yes, the first test seems not needed. My brain was buffering! I will revisit the test casesand make an update later. > > Best regards, > -- > Chao Li (Evan) > HighGo Software Co., Ltd. > https://www.highgo.com/ > PFA v6. The two test cases on table level “IF EXISTS” are removed. So, now the patch adds totally 4 test cases: 2 for omittingCOLUMN, 2 for combinations of column level “IF [NOT] EXISTS” and omitting COUMN. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Вложения
В списке pgsql-hackers по дате отправления: