> o fmtId() returns pointer to a static memory in it. In the meantime
> there is a line where is fmtId() called twice without saving the first
> value returned by fmtId(). So second call to fmtId() will break the
> first one.
>
> o findTableByName() looks up a table by its name. if a table name
> contanins upper letters or non ascii chars, fmtId() will returns a
> name quoted in double quotes, which will not what findTableByName()
> wants. The result is SEG fault.
Thanks Tatsuo! But these are older problems, not new breakage from me,
right? Have you had a chance to test the latest pg_dump with your
patches? I'm still concerned that I didn't test pg_dump with a
regression test dump/reload/dump sequence (by comparing the two dump
files).
- Tom