Re: Miscellaneous changes to plperl [PATCH]

On Sat, Jan 23, 2010 at 12:42, David E. Wheeler <david@kineticode.com> wrote:
> On Jan 23, 2010, at 11:20 AM, Alex Hunsaker wrote:
>
>> Well no, i suppose we could fix that via:
>> $name =~ s/[:|']/_/g;
>>
>> Im betting that was the intent.
>
> Doubtful. In Perl, the package separator is either `::` or `'` (for hysterical reasons). So the original code was
replacingany package separator with a single underscore. Your regex would change This::Module to This__Module, which
I'mcertain was not the intent. 

Haha, yep your right.  I could have sworn I tested it with a function
name with a ' and it broke.  But your obviously right :)