On Thu, Jun 12, 2008 at 11:35 AM, Alvaro Herrera
<alvherre@commandprompt.com> wrote:
> I don't think there's anything wrong with that in principle. However,
> does your patch actually work? The changes in expected/ is unexpected,
> I think.
Yeah I thought they looked a bit odd at first to. I thought it would
just get rid of the duplicate NOTICES's. On closer look they don't
NOITCE anymore because all the tables are listed in the drop. Here is
an example:
# with all them in in drop table
create table test (a int primary key);
create table test_a (a int references test);
create table test_b (a int references test);
drop table test, test_a, test_b cascade;
DROP TABLE
# now without test_b
create table test (a int primary key);
create table test_a (a int references test);
create table test_b (a int references test);
drop table test, test_a cascade;
NOTICE: drop cascades to constraint test_b_a_fkey on table test_b
DROP TABLE
In fact you don't even need the cascade anymore if you specify all the
dependent tables.
So that certainly *seems* right to me.