Re: Remove unnecessary else branch

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Remove unnecessary else branch
Дата
Msg-id 3438915.1602602703@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Remove unnecessary else branch  (Li Japin <japinli@hotmail.com>)
Список pgsql-hackers
Li Japin <japinli@hotmail.com> writes:
> I agree with Heikki from the code execution point of view.

> In code execution point of view they are same, however, the code is for user, i think the readability is also
important.

There is another consideration here, which is avoiding creating
back-patching hazards from gratuitous cross-branch code differences.

If you need to rewrite a chunk of logic anyway, then fixing
small cosmetic issues in it is fine.  Otherwise I think "leave
well enough alone" is a good guiding principle.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Assertion failure with LEFT JOINs among >500 relations
Следующее
От: Heikki Linnakangas
Дата:
Сообщение: Re: partition routing layering in nodeModifyTable.c