Re: bug in COPY

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Tom Lane wrote:
>> The exclamation point seems inappropriate.  Perhaps "zero-length input"
>> would be better than "string" also.

> I copied the other test case:

>     if (s == (char *) NULL)
>         elog(ERROR, "pg_atoi: NULL pointer!"); 

Well, the NULL-pointer test might equally well be coded as an Assert:
it's to catch backend coding errors, not cases of incorrect user input.
So the exclamation point there didn't bother me.

> I removed them both '!'.

If you like.  But the two conditions are not comparable.
        regards, tom lane