Re: Incorrect Assert in BufFileSize()?

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Incorrect Assert in BufFileSize()?
Дата
Msg-id 3260453.1720023558@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Incorrect Assert in BufFileSize()?  (David Rowley <dgrowleyml@gmail.com>)
Ответы Re: Incorrect Assert in BufFileSize()?
Список pgsql-hackers
David Rowley <dgrowleyml@gmail.com> writes:
> I've attached an updated patch which updates the comments and also
> removes the misplaced Asserts from BufFileAppend.
> If there are no objections or additional feedback, I'll push this patch soon.

- * Return the current fileset based BufFile size.
+ * Returns the size if the given BufFile in bytes.

"Returns the size of", no doubt?

A shade less nit-pickily, I wonder if "size" is sufficient.
It's not really obvious that this means the amount of data
in the file, rather than say sizeof(BufFile).  How about

+ * Returns the amount of data in the given BufFile, in bytes.

LGTM other than that point.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Marat Bukharov
Дата:
Сообщение: Re: [PATCH] Add min/max aggregate functions to BYTEA
Следующее
От: Daniel Gustafsson
Дата:
Сообщение: Re: Add support to TLS 1.3 cipher suites and curves lists