Re: Insufficient memory access checks in pglz_decompress
| От | Tom Lane |
|---|---|
| Тема | Re: Insufficient memory access checks in pglz_decompress |
| Дата | |
| Msg-id | 3235130.1697676483@sss.pgh.pa.us обсуждение исходный текст |
| Ответ на | Re: Insufficient memory access checks in pglz_decompress (Flavien GUEDEZ <flav.pg@oopacity.net>) |
| Ответы |
Re: Insufficient memory access checks in pglz_decompress
|
| Список | pgsql-bugs |
Flavien GUEDEZ <flav.pg@oopacity.net> writes:
> Thanks for your feedback, you are definitely right, I did not notice
> that (dp - off) was staying the same in the while loop.
> Here is another much smaller patch.
I thought of another thing we should change: it's better to perform
the test as "off > (dp - dest)" than the way you formulated it.
"dp - dest" is certainly computable, since it's the number of bytes
we've written to the output buffer so far. But "dp - off" could,
with bad luck and a buffer near the start of memory, wrap around
to look like it's after "dest".
Pushed with that change and a little fiddling with the comment.
Thanks for the report!
regards, tom lane
В списке pgsql-bugs по дате отправления: