Re: pgsql: Initialize unused ExprEvalStep fields.

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Initialize unused ExprEvalStep fields.
Дата
Msg-id 32346.1517257019@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Initialize unused ExprEvalStep fields.  (Andres Freund <andres@anarazel.de>)
Ответы Re: pgsql: Initialize unused ExprEvalStep fields.  (Andres Freund <andres@anarazel.de>)
Список pgsql-committers
Andres Freund <andres@anarazel.de> writes:
> Initialize unused ExprEvalStep fields.
> ExecPushExprSlots didn't initialize ExprEvalStep's resvalue/resnull
> steps as it didn't use them. That caused wrong valgrind warnings for
> an upcoming patch, so zero-intialize.

Check ...

> Also zero-initialize all scratch ExprEvalStep's allocated on the
> stack, to avoid issues with similar future omissions of non-critial
> data.

Dunno that that's a good idea; it will also serve to hide valid warnings.

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: pgsql: Save a few bytes by removing useless last argument toSearchCatC
Следующее
От: Andres Freund
Дата:
Сообщение: pgsql: Introduce ExecQualAndReset() helper.