Re: Remove repeated calls to PQserverVersion

Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Jul 13, 2021 at 07:02:27PM +1000, Peter Smith wrote:
>> I found a few functions making unnecessary repeated calls to
>> PQserverVersion(conn); instead of just calling once and assigning to a
>> local variable.

> Does it really matter?  PQserverVersion() does a simple lookup at the
> internals of PGconn.

Yeah, it'd have to be mighty hot code to be worth caring about that,
and none of these spots look like it could be worth it.

            regards, tom lane