Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
Дата
Msg-id 31996.1563509161@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: pgsql: Sync our copy of the timezone library with IANA releasetzcode20  (Michael Paquier <michael@paquier.xyz>)
Ответы Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> This is causing a compilation warning on Windows:

>  src/timezone/zic.c(2401): warning C4804: '-' : unsafe use of type
>   'bool' in operation

Hmmm ... the code looks like

        bool        locut,
                    hicut;
        ...
        thistimecnt = -locut - hicut;

so I think your compiler has a point.  I shall complain to upstream.
At best, it's really unobvious what this code is meant to do, and
at worst (eg, depending on whether bool promotes to signed or unsigned
int) the results are unportable.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Hubert Zhang
Дата:
Сообщение: How to create named portal except cursor?
Следующее
От: Amit Kapila
Дата:
Сообщение: Re: POC: Cleaning up orphaned files using undo logs