Re: [PATCH] pgbench tap tests fail if the path contains a perl special character

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] pgbench tap tests fail if the path contains a perl special character
Дата
Msg-id 31298.1548087022@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character  (Andrew Dunstan <andrew.dunstan@2ndquadrant.com>)
Ответы Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character  (Fabien COELHO <coelho@cri.ensmp.fr>)
Список pgsql-hackers
Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> Perhaps it would be OK we changed back the glob line to use $prefix
> instead of $qprefix, but kept the use of $qprefix in the later regex.

Well, glob does have some metacharacters, so not doing any quoting
at all still leaves us with failure modes.

I did a little bit of googling on this subject last night, and it
seems that at least some people believe that the answer is to not
use glob, period, but read the directory for yourself.  Maybe there's
a better way, but the breakage around backslashes doesn't really
leave me hopeful.

As a short-term move to un-break the buildfarm, I'm just going to
revert that patch altogether.  We can reapply it once we've
figured out how to do the glob part correctly.

            regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andrew Dunstan
Дата:
Сообщение: Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character
Следующее
От: Fabien COELHO
Дата:
Сообщение: Re: [PATCH] pgbench tap tests fail if the path contains a perlspecial character