Re: lwlocknames.h beautification attempt

Gurjeet Singh <gurjeet@singh.im> writes:
> I propose the following change to the generation script,
> generate-lwlocknames.pl
> ...
> which produces the lock names in this format

> #define ShmemIndexLock                 (&MainLWLockArray[1].lock)
> #define OidGenLock                     (&MainLWLockArray[2].lock)
> #define XidGenLock                     (&MainLWLockArray[3].lock)
> #define ProcArrayLock                  (&MainLWLockArray[4].lock)
> #define SInvalReadLock                 (&MainLWLockArray[5].lock)

This looks reasonably in line with project style ...

> Yet another format, which I prefer, can be achieved by right-aligning the
> lock names.

> #define                 ShmemIndexLock (&MainLWLockArray[1].lock)
> #define                     OidGenLock (&MainLWLockArray[2].lock)
> #define                     XidGenLock (&MainLWLockArray[3].lock)
> #define                  ProcArrayLock (&MainLWLockArray[4].lock)
> #define                 SInvalReadLock (&MainLWLockArray[5].lock)

... but that doesn't.  I challenge you to provide even one example
of that layout in our source tree, or to explain why it's better.

            regards, tom lane