Re: Adding some error context for lock wait failures

Andres Freund <andres@anarazel.de> writes:
> There are a few places that do
>     ereport(...);

>     /* Flush any strings created in ErrorContext */
>     FlushErrorState();

> That'd be obsoleted by this change, right?

Oh, I see them, all in guc.c.  Yeah, we should get rid of those;
they seem not too safe anyway given that they're unconditional.

>> Do you have an opinion on whether to back-patch?

> I'm a bit worried about it causing problems, although I don't have an actual
> theory as to how. So I'd slightly lean towards not backpatching. But it's just
> a vague gut feeling.

Fair enough.  We can always back-patch later if someone exhibits
an actual problem in the field.

            regards, tom lane