Re: pgsql: Fix WAL replay of locking an updated tuple

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: pgsql: Fix WAL replay of locking an updated tuple
Дата
Msg-id 30633.1393512063@sss.pgh.pa.us
обсуждение исходный текст
Ответ на pgsql: Fix WAL replay of locking an updated tuple  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: pgsql: Fix WAL replay of locking an updated tuple  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Re: pgsql: Fix WAL replay of locking an updated tuple  (Andres Freund <andres@2ndquadrant.com>)
Список pgsql-committers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Fix WAL replay of locking an updated tuple

The test added by this patch certainly looks like it's backwards.
Shouldn't you be clearing HOT_UPDATED only if the tuple is *not*
XMAX_IS_LOCKED_ONLY?

If the code is actually correct as written, then I think that test
macro is very unfortunately named.

            regards, tom lane


В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Fix WAL replay of locking an updated tuple
Следующее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: doc: bgw_main takes a Datum argument, not void *.