Re: suspicious valgrind reports about radixtree/tidstore on arm64

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: suspicious valgrind reports about radixtree/tidstore on arm64
Дата
Msg-id 304198.1718870463@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: suspicious valgrind reports about radixtree/tidstore on arm64  (John Naylor <johncnaylorls@gmail.com>)
Список pgsql-hackers
John Naylor <johncnaylorls@gmail.com> writes:
> On Thu, Jun 20, 2024 at 8:12 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> IIUC there is no particular reason for the current order in RT_NODE_48.

> Yeah. I found that simply swapping them enables clang to avoid
> double-initialization, but gcc still can't figure it out and must be
> told to stop at slot_idxs[]. I'd prefer to do it that way and document
> that slot_idxs is purposefully the last member of the fixed part of
> the struct.

WFM.

> If that's agreeable I'll commit it that way tomorrow
> unless someone beats me to it.

I was going to push it, but feel free.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: John Naylor
Дата:
Сообщение: Re: suspicious valgrind reports about radixtree/tidstore on arm64
Следующее
От: Kyotaro Horiguchi
Дата:
Сообщение: Re: [HACKERS] make async slave to wait for lsn to be replayed