Re: Less than ideal error reporting in pg_stat_statements

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Less than ideal error reporting in pg_stat_statements
Дата
Msg-id 30415.1443996994@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Less than ideal error reporting in pg_stat_statements  (Peter Geoghegan <pg@heroku.com>)
Ответы Re: Less than ideal error reporting in pg_stat_statements  (Andrew Dunstan <andrew@dunslane.net>)
Re: Less than ideal error reporting in pg_stat_statements  (Peter Geoghegan <pg@heroku.com>)
Список pgsql-hackers
Peter Geoghegan <pg@heroku.com> writes:
> To be clear: I wasn't sure why you though I falsely count entries with
> dropped texts within entry_dealloc().

In the existing^H^H^Hprevious code, dropped-text entries would essentially
act as length-zero summands in the average calculation, whereas I think
we agree that they ought to be ignored; otherwise they decrease the
computed mean and thereby increase the probability of (useless) GC cycles.
In the worst case where the hashtable is mostly dropped-text entries,
which would for instance be the prevailing situation shortly after a GC
failure, we'd be calculating ridiculously small mean values and that'd
prompt extra GC cycles no?
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Less than ideal error reporting in pg_stat_statements
Следующее
От: Nathan Wagner
Дата:
Сообщение: Re: No Issue Tracker - Say it Ain't So!]