Re: Inefficiency in parallel pg_restore with many tables

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Inefficiency in parallel pg_restore with many tables
Дата
Msg-id 3031359.1694649699@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Inefficiency in parallel pg_restore with many tables  (Nathan Bossart <nathandbossart@gmail.com>)
Ответы Re: Inefficiency in parallel pg_restore with many tables  (Nathan Bossart <nathandbossart@gmail.com>)
Список pgsql-hackers
Nathan Bossart <nathandbossart@gmail.com> writes:
> Upon closer inspection, I found a rather nasty problem.  The qsort
> comparator expects a TocEntry **, but the binaryheap comparator expects a
> TocEntry *, and we simply pass the arguments through to the qsort
> comparator.  In v9, I added the requisite ampersands.

Ooops :-(

> I'm surprised this
> worked at all.

Probably it was not sorting things appropriately.  Might be worth adding
some test scaffolding to check that bigger tasks are chosen before
smaller ones.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: David Rowley
Дата:
Сообщение: Re: Surely this code in setrefs.c is wrong?
Следующее
От: Andy Fan
Дата:
Сообщение: Re: Redundant Unique plan node for table with a unique index