Re: Remove redundant variable from transformCreateStmt

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Remove redundant variable from transformCreateStmt
Дата
Msg-id 3029443.1619710920@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: Remove redundant variable from transformCreateStmt  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: Remove redundant variable from transformCreateStmt
Список pgsql-hackers
Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> I'd do it like this.  Note I removed an if/else block in addition to
> your changes.

> I couldn't convince myself that this is worth pushing though; either we
> push it to all branches (which seems unwarranted) or we create
> back-patching hazards.

Yeah ... an advantage of the if/else coding is that it'd likely be
simple to extend to cover additional statement types, should we ever
wish to do that.  The rendering you have here is nice and compact,
but it would not scale up well.

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: default_tablespace doc and partitioned rels
Следующее
От: vignesh C
Дата:
Сообщение: Included xid in restoring reorder buffer changes from disk log message