Re: [PATCH] Expand character set for ltree labels

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCH] Expand character set for ltree labels
Дата
Msg-id 3010914.1673022571@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCH] Expand character set for ltree labels  (Andrew Dunstan <andrew@dunslane.net>)
Ответы Re: [PATCH] Expand character set for ltree labels  (Andrew Dunstan <andrew@dunslane.net>)
Список pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2022-10-05 We 18:05, Garen Torikian wrote:
>> Therefore I have updated the patch with three much smaller changes:
>> 
>> * Support for `-` in addition to `_`
>> * Expanding the limit to 512 chars (from the existing 256); again it's
>> not uncommon for non-English strings to be much longer
>> * Fixed the documentation to expand on what the ltree label's
>> relationship to the DB locale is

> Regardless of the punycode issue, allowing hyphens in ltree labels seems
> quite reasonable. I haven't reviewed the patch yet, but if it's OK I
> intend to commit it.

No objection to allowing hyphens.  If we're going to increase the length
limit, how about using 1000 characters?  AFAICS we could even get away
with 10K, but it's probably best to hold a bit or two in reserve in case
we ever want flags or something associated with labels.

(I've not read the patch.)

            regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Tom Lane
Дата:
Сообщение: Re: Logical replication - schema change not invalidating the relation cache
Следующее
От: Tom Lane
Дата:
Сообщение: Re: postgres_fdw: using TABLESAMPLE to collect remote sample